Skip to content

Pipe/Subscription: Add 'Create If Not Exists' and 'Drop If Exists' Support for Pipes, Plugins, and Topics#12969

Merged
SteveYurongSu merged 34 commits intoapache:masterfrom
luoluoyuyu:if-not-exists-support
Aug 1, 2024
Merged

Pipe/Subscription: Add 'Create If Not Exists' and 'Drop If Exists' Support for Pipes, Plugins, and Topics#12969
SteveYurongSu merged 34 commits intoapache:masterfrom
luoluoyuyu:if-not-exists-support

Conversation

@luoluoyuyu
Copy link
Copy Markdown
Member

@luoluoyuyu luoluoyuyu commented Jul 18, 2024 •
edited
Loading

Description

As title.

This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.
Key changed/added classes (or packages if there are too many classes) in this PR

@luoluoyuyu luoluoyuyu marked this pull request as draft July 18, 2024 14:45
@SteveYurongSu SteveYurongSu self-assigned this Jul 19, 2024
Caideyipi
Caideyipi reviewed Jul 19, 2024
View reviewed changes
@luoluoyuyu luoluoyuyu marked this pull request as ready for review July 22, 2024 03:42
Caideyipi
Caideyipi reviewed Jul 23, 2024
View reviewed changes
VGalaxies
VGalaxies reviewed Jul 24, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@VGalaxies VGalaxies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor issues with the comments~

Caideyipi
Caideyipi reviewed Jul 25, 2024
View reviewed changes
@Caideyipi
Copy link
Copy Markdown
Collaborator

Caideyipi commented Jul 25, 2024

BTW, are we planning to forbid the drop of PipePlugin when there are any topics using it in this PR?

@luoluoyuyu
Copy link
Copy Markdown
Member Author

luoluoyuyu commented Jul 25, 2024

BTW, are we planning to forbid the drop of PipePlugin when there are any topics using it in this PR?

This should be addressed in another PR.

Caideyipi
Caideyipi approved these changes Jul 26, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@Caideyipi Caideyipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SteveYurongSu SteveYurongSu merged commit 43e562a into apache:master Aug 1, 2024
JackieTien97 pushed a commit that referenced this pull request Aug 8, 2024
@luoluoyuyu @SteveYurongSu @JackieTien97
Pipe/Subscription: Add 'Create If Not Exists' and 'Drop If Exists' Su…
2d5f2b3 
…pport for Pipes, Plugins, and Topics (#12969)

Co-authored-by: Steve Yurong Su <rong@apache.org>
(cherry picked from commit 43e562a)
JackieTien97 pushed a commit that referenced this pull request Aug 8, 2024
@luoluoyuyu @SteveYurongSu @JackieTien97
Pipe/Subscription: Add 'Create If Not Exists' and 'Drop If Exists' Su…
c416846 
…pport for Pipes, Plugins, and Topics (#12969)

Co-authored-by: Steve Yurong Su <rong@apache.org>
(cherry picked from commit 43e562a)
@luoluoyuyu luoluoyuyu deleted the if-not-exists-support branch August 19, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@VGalaxies VGalaxies VGalaxies left review comments

@SteveYurongSu SteveYurongSu SteveYurongSu approved these changes

@Caideyipi Caideyipi Caideyipi approved these changes

Assignees

@SteveYurongSu SteveYurongSu

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@luoluoyuyu @Caideyipi @SteveYurongSu @VGalaxies